HomePhorge

(#15027, #15028, #15029) Fix upstart version parsing
2911fec58227Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#15027, #15028, #15029) Fix upstart version parsing

A leading space in the --version argument would confuse upstart, and the
version returned would not always be a semantic version, which caused the
upstart provider to fail. This commit updates the initctl call to remove the
leading space from the --version argument, and also replaces the implicit
SemVer comparisons with wrapper functions that call out to
Puppet::Util::Package.versioncmp to do version comparisons. It also fixes a
subtly broken regex to grab the full version string.

Details

Provenance
Matthaus Litteken <matthaus@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUf92aefacdb51: Update CHANGELOG, conf/redhat/puppet.spec for 2.7.16
Branches
Unknown
Tags
Unknown

Event Timeline

Matthaus Litteken <matthaus@puppetlabs.com> committed rPU2911fec58227: (#15027, #15028, #15029) Fix upstart version parsing (authored by Matthaus Litteken <matthaus@puppetlabs.com>).Jun 15 2012, 6:11 PM