HomePhorge

(PUP-2738) Puppet::Util::Windows::File FFI cleanup
2631a6fda689Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-2738) Puppet::Util::Windows::File FFI cleanup

  • Break resolve_symlink into an additional helper to simplify memory usage / cleanup. Each time an FFI::MemoryPointer is encountered, it's cleaned up immediately after use. Structure code to ensure that a REPARSE_DATA_BUFFER is returned from resolve_symlink rather than a FFI::MemoryPointer
  • Ensure that Puppet::Util::Windows::File.resolve_symlink return value is given default, and closed on inside block to prevent incorrect return value.

Details

Provenance
Ethan J. Brown <Iristyle@github>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUe0a7b41433c4: (PUP-2738) open_symlink should wide_string once
Branches
Unknown
Tags
Unknown

Event Timeline

Ethan J. Brown <Iristyle@github> committed rPU2631a6fda689: (PUP-2738) Puppet::Util::Windows::File FFI cleanup (authored by Ethan J. Brown <Iristyle@github>).Jun 18 2014, 9:14 PM