HomePhorge

(PUP-1635) Make daemon.rb signals Ruby 2.x safe
245de036f676Unpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

(PUP-1635) Make daemon.rb signals Ruby 2.x safe

Ruby 2.x changes the way signals work to mean you can't do certain things from the 'trap context'. This means that SIGUSR1 and the like no longer work.

This change makes it so that we, instead of processing methods in the 'trap context', just store them on a list and pop them out the other side in another job called signal_loop.

This is modelled on the way other Ruby Daemon-like projects have fixed this issue.

Details

Provenance
Lee Packham <lpackham@leenux.org.uk>Authored on
Kylo Ginsberg <kylo@puppetlabs.com>Committed on Mar 4 2015, 6:19 AM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU7cfe10d7b466: Merge pull request #3667 from hlindberg/PUP-4054_remove-unhelpful-exception…
Branches
Unknown
Tags
Unknown

Event Timeline

Kylo Ginsberg <kylo@puppetlabs.com> committed rPU245de036f676: (PUP-1635) Make daemon.rb signals Ruby 2.x safe (authored by Lee Packham <lpackham@leenux.org.uk>).Mar 4 2015, 6:19 AM