HomePhorge

(PUP-1563) resolve_install_conflicts excessively recurses
218e0f1cab52Unpublished

Unpublished Commit · Learn More

Repository Importing: This repository is still importing.

Description

(PUP-1563) resolve_install_conflicts excessively recurses

Previously, resolve_install_conflicts was called from inside the
modules_by_path iterator causing each module and its dependencies to be
checked for conflict for each installed module, even if the installed
module was completely unrelated. With a tree of dependencies and dozens
of previously installed modules, this walk can take hours.

This patch fixed the problem by moving the recursion outside of the
modules_by_path iterator loop.

Details

Provenance
Joe Julian <me@joejulian.name>Authored on
Josh Cooper <josh@puppetlabs.com>Committed on Mar 7 2014, 8:48 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUbfc60db48092: Merge pull request #2307 from kylog/issue/pup-640/report-schema-updates-for…
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPU218e0f1cab52: (PUP-1563) resolve_install_conflicts excessively recurses (authored by Joe Julian <me@joejulian.name>).Mar 7 2014, 8:48 PM