HomePhorge

(#19148) don't embed a Racc parser in naginator
20bf8129156bUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#19148) don't embed a Racc parser in naginator

Naginator embeds a parser engine which clashes with the one the DSL is
using. This leads to noisy runs like this:

$ puppet apply -e 'nagios_host {"foo":}'
racc/parser.rb:27: warning: already initialized constant Racc_Runtime_Version
racc/parser.rb:28: warning: already initialized constant Racc_Runtime_Revision
racc/parser.rb:30: warning: already initialized constant Racc_Runtime_Core_Version_R
racc/parser.rb:31: warning: already initialized constant Racc_Runtime_Core_Revision_R
racc/parser.rb:35: warning: already initialized constant Racc_Runtime_Core_Revision_C
racc/parser.rb:39: warning: already initialized constant Racc_Main_Parsing_Routine
racc/parser.rb:40: warning: already initialized constant Racc_YY_Parse_Method
racc/parser.rb:41: warning: already initialized constant Racc_Runtime_Core_Version
racc/parser.rb:42: warning: already initialized constant Racc_Runtime_Core_Revision
racc/parser.rb:43: warning: already initialized constant Racc_Runtime_Type
Finished catalog run in 0.08 seconds

The fix is simply to not embed the parser engine, and use the same one as the puppet DSL.

Details

Provenance
Richard Clamp <richardc@unixbeard.net>Authored on
Jeff McCune <jeff@puppetlabs.com>Committed on Feb 8 2013, 6:51 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUc8bdc3a74407: tweak the nagios grammar.ry so it reflects the parser
Branches
Unknown
Tags
Unknown

Event Timeline

Jeff McCune <jeff@puppetlabs.com> committed rPU20bf8129156b: (#19148) don't embed a Racc parser in naginator (authored by Richard Clamp <richardc@unixbeard.net>).Feb 8 2013, 6:51 PM