HomePhorge

(#7291) Fix Ruby 1.9 face failures
1abb7c086f2dUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(#7291) Fix Ruby 1.9 face failures

The certificate face wasn't being loaded, but it wasn't clear from the
test failure why:

lib/puppet/interface.rb:61:in `[]': Could not find Puppet Face
:certificate (Puppet::Error)

The problem is that when the certificate face is required you get:

SyntaxError Exception:
/Users/matthewrobinson/work/puppet/lib/puppet/face/certificate.rb:11:
invalid multibyte char (US-ASCII)

However this error is caught and logged, but then ignored. This
behavior was a decision in #7314 and is currently under review.

A space character in the description was ASCII 160 instead of the typical ASCII 32

Reviewed-by: Pieter van de Bruggen <pieter@puppetlabs.com>

Details

Provenance
Matt Robinson <matt@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU615946619b71: (#7291) The 'script' version of actions needs options argument
Branches
Unknown
Tags
Unknown

Event Timeline

Matt Robinson <matt@puppetlabs.com> committed rPU1abb7c086f2d: (#7291) Fix Ruby 1.9 face failures (authored by Matt Robinson <matt@puppetlabs.com>).May 17 2011, 12:13 AM