HomePhorge

[15929] [17624] Handle malformed plists
16d2d9a855f3Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

[15929] [17624] Handle malformed plists

Previously, if launchd encountered a plist that did NOT have a 'label' key, or
a malformed plist that plutil couldn't read, Puppet would throw a stacktrace or
log a nebulous error that looked like:

`Error: Could not run: No resource and no name in property hash in launchd
instance`

That was not ideal. This commit will catch the situation where a plist is
missing a 'label' key Puppet is skipping the plist. It will also catch the
case the where a plist is malformed and plutil cannot read it. With either
condition, the commit adds code that logs a Puppet.warning and skips the
malformed plist gracefully.

Details

Provenance
Gary Larizza <gary@puppetlabs.com>Authored on
Jeff McCune <jeff@puppetlabs.com>Committed on Dec 5 2012, 1:33 AM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU76779bcf312d: Merge branch 'glarizza-bug/3.0.x/12833_fix_salt' into 3.0.x
Branches
Unknown
Tags
Unknown

Event Timeline

Jeff McCune <jeff@puppetlabs.com> committed rPU16d2d9a855f3: [15929] [17624] Handle malformed plists (authored by Gary Larizza <gary@puppetlabs.com>).Dec 5 2012, 1:33 AM