HomePhorge

Remove duplicate SID resolution code
15149c10902bUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Remove duplicate SID resolution code

Previously the User and Group classes defined their own method for
resolving a name into a SID with the assumption that we might need to
customize the WMI query for each type of object (by including the
SIDType in the where clause). But it turns out that the Name and
Domain properties of the Win32_Account table are a compound key, so
the method for resolving names into SIDs can be refactored.

Also, eliminated duplicate, and slightly incorrect code from the
Windows security integration test (it wasn't restricting the query to
local accounts only).

Details

Provenance
Nick Lewis <nick@puppetlabs.com>Authored on
Josh Cooper <josh@puppetlabs.com>Committed on Sep 27 2011, 8:16 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUf93251172ca7: Move owner management into providers
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPU15149c10902b: Remove duplicate SID resolution code (authored by Nick Lewis <nick@puppetlabs.com>).Sep 27 2011, 8:16 PM