HomePhorge

(maint) Reorder code to increase clarity
105dc4bbadd0Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(maint) Reorder code to increase clarity

There were a lot of unless cases that made it hard for me to track down
the path of what was actually accepted. This inverts the branches so
that the if statements lay out what is required for the good case and
the else clauses express the various failures.

In addition there were a few error scenarios where reordering was
possible and reduced the amount of work that needed to be done before
the error was detected.

Details

Provenance
Andrew Parker <andy@puppetlabs.com>Authored on
Josh Cooper <josh@puppetlabs.com>Committed on May 16 2014, 11:54 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUab1ced75d224: (PUP-2568) Downcase class name before validating
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPU105dc4bbadd0: (maint) Reorder code to increase clarity (authored by Andrew Parker <andy@puppetlabs.com>).May 16 2014, 11:54 PM