HomePhorge

maint: Unify 'type' and 'classref' non-terminals in the grammar
0e6d0a4c46ccUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

maint: Unify 'type' and 'classref' non-terminals in the grammar

These both wrapped the CLASSREF token, except 'type' created an
AST::Type object, whereas 'classref' just extracted the string value.
This change removes the 'classref' non-terminal, replacing its uses with
'type' and explicitly extracting the string value from the AST::Type
instance.

Ideally, this should probably either retain the AST::Type object and
evaluate it where it's used, or remove the AST::Type leaf entirely, as
it has no actual behavior of its own.

Also removed some dead warnings (they were warning on a lower-case type,
which can't happen).

Details

Provenance
Nick Lewis <nick@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU8ae917aaeabc: Merge branch 'tickets/2.7.x/6412' into 2.7.x
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Lewis <nick@puppetlabs.com> committed rPU0e6d0a4c46cc: maint: Unify 'type' and 'classref' non-terminals in the grammar (authored by Nick Lewis <nick@puppetlabs.com>).Dec 13 2011, 11:48 PM