HomePhorge

(PUP-1699) Add remote environment to plugin downloader calls
0dfce8a43382Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-1699) Add remote environment to plugin downloader calls

Puppet::Configurer::Downloader is also called by the plugin face, but we
were not submitting an environment there. On Ruby 1.9.3 this nil
environment was being interned as :'' and would produce a failure server
side when a request with an empty environment was parsed. On Ruby
1.8.7, nil raises an error when interned and it was failing much sooner
on the agent side.

To resolve this, we're passing in a reference to the configured
environment. Also added an integration test for the plugin face, because we
weren't seeing any failure in our test suite.

Details

Provenance
Josh Partlow <joshua.partlow@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU2a2ef7d26de8: (PUP-1699) Tie resource environment to catalog
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Partlow <joshua.partlow@puppetlabs.com> committed rPU0dfce8a43382: (PUP-1699) Add remote environment to plugin downloader calls (authored by Josh Partlow <joshua.partlow@puppetlabs.com>).Apr 28 2014, 11:04 PM