HomePhorge

Fixes #4792 (Duplicate definition since 2.6.1 upgrade)
0aaa742e0f09Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Fixes #4792 (Duplicate definition since 2.6.1 upgrade)

The evaluate_definitions method was first figuring out which resources
needed to be evaluated (using unevaluated_resources), and then
evaluating them one by one. As a result, if evaluating one resource
triggered another resource to be evaluated, the latter resource could
get evaluated twice. This bug could occur, for example, if both
resources were classes that were included into the node by an external
node classifier, and if the first of the two classes included the
second.

Modified Resource#evaluate to be idempotent.

Also added an integration test to verify the fix.

Details

Provenance
Paul Berry <paul@puppetlabs.com>Authored on
Markus Roberts <Markus@reality.com>Committed on Sep 30 2010, 11:14 PM
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPUea49d13192fc: Improvement to #4025: made spec tests work on all platforms
Branches
Unknown
Tags
Unknown

Event Timeline

Markus Roberts <Markus@reality.com> committed rPU0aaa742e0f09: Fixes #4792 (Duplicate definition since 2.6.1 upgrade) (authored by Paul Berry <paul@puppetlabs.com>).Sep 30 2010, 11:14 PM