(PUP-3912) Convert some 'should's to 'expect's that weren't previously found

These were a couple outlier uses of 'should' not caught either by
transpec, or by the purge of 'must' for different reasons:

• provider_spec.rb had some metaprogrammed use of should
• semver_spec.rb had a should in a bare 'describe' block