HomePhorge

(PUP-2689) Make AST Resource check tags against "inherited" tags
0436eb1e0997Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-2689) Make AST Resource check tags against "inherited" tags

This overrides the tagged? method in AST Resource to also search
for tags in its containing resource. These tags will be set when
the resource is finalized (just before serialization on transformation
to external format).

If this is not done, resources will have a different tag set when
a search is made for the node itself (exported or virtual) vs. searching
external resources.

This also correct minor problems with passing an array (which could
result in an array being set as a tag).
It was also possible for empty tags to be set if a string tag contained
multiple :: in sequence, or if ending with ::. Now an error is raised
for these conditions (just like for empty segments generated by using a
sequence of commas (which was on a different code path).

Details

Provenance
Henrik Lindberg <henrik.lindberg@cloudsmith.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU31545fa2ed5b: (maint) Remove unused Puppet::Parser::AST::Tag class
Branches
Unknown
Tags
Unknown

Event Timeline

Henrik Lindberg <henrik.lindberg@cloudsmith.com> committed rPU0436eb1e0997: (PUP-2689) Make AST Resource check tags against "inherited" tags (authored by Henrik Lindberg <henrik.lindberg@cloudsmith.com>).May 30 2014, 8:07 PM