HomePhorge

(PUP-744) Remove private Connection#connection method
02b0deb4b9ccUnpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(PUP-744) Remove private Connection#connection method

Previously, the Connection#connection method was used in
connection_spec.rb to validate the state of the Net::HTTP object
created by the puppet connection.

Since the puppet connection no longer owns an Net::HTTP object (it may
use newly created or cached instances), the #connection method
doesn't make sense, and since it was private, can be removed.

The tests that relied on the private method have been updated, and in
some cases moved to the factory_spec, e.g. verifying proxy settings.

Details

Provenance
Josh Cooper <josh@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU6c55f762f938: (maint) Update comment about request_* methods
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cooper <josh@puppetlabs.com> committed rPU02b0deb4b9cc: (PUP-744) Remove private Connection#connection method (authored by Josh Cooper <josh@puppetlabs.com>).Jul 25 2014, 6:36 PM