HomePhorge

(maint) Untangle fetching of serial numbers
018cc7346f20Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

(maint) Untangle fetching of serial numbers

The previous code contained a large number of assignments in passing
inside the conditional expressions. This caused it to need to use the
"and" operator, which should be reserved for control flow, to be used as
a boolean expression in order to avoid having the list of serial numbers
be a boolean as a result of precedence. This also resulted in the name
"serial" being used, when in fact it is now a collection of 0 or more
serial numbers. It also had the structure where the final array could
have been an array of arrays and so flatten needed to be used.

This straightens all of that out by ensuring that serials is always an
array and performing common error checking and handling of that.

Details

Provenance
Andrew Parker <andy@puppetlabs.com>Authored on
vanmeeuwenPushed on Jun 2 2015, 2:22 PM
Parents
rPU22a62c5df255: (PUP-2569) Revoke all certificate matching a given name
Branches
Unknown
Tags
Unknown

Event Timeline

Andrew Parker <andy@puppetlabs.com> committed rPU018cc7346f20: (maint) Untangle fetching of serial numbers (authored by Andrew Parker <andy@puppetlabs.com>).Jun 11 2014, 7:49 PM