HomePhorge
Diffusion guam 7db53d9c3fc0

Allow empty lines in commands.

Description

Allow empty lines in commands.

During DIGEST-MD5 authentication the client response with a an empty
line (Just \r\n). eimap_utils:split_command_into_components Either
returns a full command or an empty one, and thus cannot differentiate
between an empty and an incomplete command, and then erroneously tries
to buffer until the rest arrives (which is not existinent).
Ideally we would fix split_command_into_components into returning
something entirely different if the command is empty but complete,
but this fixes the problem at hand by matching for that special case.

Details

Provenance
Christian Mollekopf <chrigi_1@fastmail.fm>Authored on Feb 19 2018, 4:52 PM
mollekopfPushed on Feb 19 2018, 5:04 PM
Parents
rG96b24e4a4cf9: Merge branch 'release/0.9.3' into develop
Branches
Unknown
Tags
Unknown
Build Status
Buildable 14878

Event Timeline

Christian Mollekopf <chrigi_1@fastmail.fm> committed rG7db53d9c3fc0: Allow empty lines in commands. (authored by Christian Mollekopf <chrigi_1@fastmail.fm>).Feb 19 2018, 4:55 PM