Fixed apply_ruleset_clientside return value argument order.
ClosedPublic
Actions

Authored by mollekopf on Mar 20 2017, 5:25 PM.

Details

Reviewers

Commits

rGd2c2e355f634: Fixed apply_ruleset_clientside return value argument order.
rG92b6b602c213: Fixed apply_ruleset_clientside return value argument order.

Summary

With this patch I can successfully synchronize with Kontact against
kolabnow (with guam in between).

I can't push it seems.

Test Plan

Tried synchronizing with kontact.

Diff Detail

Repository

rG guam

Branch

develop

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 8805
Build 9066: arc lint + arc unit

Event Timeline

mollekopf updated this revision to Diff 939.Mar 20 2017, 5:25 PM

mollekopf retitled this revision from to Fixed apply_ruleset_clientside return value argument order..

mollekopf updated this object.

mollekopf edited the test plan for this revision. (Show Details)

mollekopf added a reviewer: • seigo.

mollekopf mentioned this in D402: Banged against guam until it works..Mar 20 2017, 5:26 PM

mollekopf mentioned this in D405: Banged against guam until it works..

Tested and approved! Thanks, Christian, for catching this refactor booboo.

This revision is now accepted and ready to land.Mar 21 2017, 9:34 AM

Closed by commit rGd2c2e355f634: Fixed apply_ruleset_clientside return value argument order. (authored by Christian Mollekopf <chrigi_1@fastmail.fm>, committed by Aaron Seigo <seigo@kolabsystems.com>). · Explain WhyMar 21 2017, 9:35 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

apps/

kolab_guam/

src/

kolab_guam_session.erl

2 lines

Diff 939

View Options

apps/kolab_guam/src/kolab_guam_session.erl

Fixed apply_ruleset_clientside return value argument order.ClosedPublicActions