Page MenuHomePhorge
Differential D3110

Unify code of various object listing methods
ClosedPublic
Actions

Authored by machniak on Dec 10 2021, 10:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 20, 11:36 PM
Unknown Object (File)
Mon, May 20, 6:55 AM
Unknown Object (File)
Sun, May 12, 3:51 AM
Unknown Object (File)
Tue, Apr 30, 11:19 AM
Unknown Object (File)
Tue, Apr 30, 11:19 AM
Unknown Object (File)
Tue, Apr 30, 11:19 AM
Unknown Object (File)
Tue, Apr 30, 11:19 AM
Unknown Object (File)
Fri, Apr 26, 5:22 PM
View All 48 Files
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK424bb0c634f5: Unify code of various object listing methods
rKc45adc958857: Unify code of various object listing methods
Summary
  • Unify User::domains()/users()/groups()/sharedFolders()/resources()
  • Unified user:domains command
  • Add user:users, user:groups, user:resources user:shared-folders
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/unified-user-mathods
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 37292
Build 14942: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Dec 10 2021, 10:53 AM
machniak created this revision.
Harbormaster completed remote builds in B37292: Diff 8813.Dec 10 2021, 10:54 AM
machniak updated this revision to Diff 8837.Dec 15 2021, 11:19 AM
  • Fix regression in User::domains()
Harbormaster completed remote builds in B37313: Diff 8837.Dec 15 2021, 11:19 AM
mollekopf accepted this revision.Dec 17 2021, 9:44 AM
This revision is now accepted and ready to land.Dec 17 2021, 9:44 AM
Closed by commit rK424bb0c634f5: Unify code of various object listing methods (authored by machniak). · Explain WhyDec 17 2021, 11:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
Commands/
User/
41 lines
13 lines
13 lines
13 lines
13 lines
18 lines
15 lines
Http/
Controllers/
API/
V4/
9 lines
12 lines
Rules/
4 lines
7 lines
7 lines
113 lines
tests/
Feature/
Console/
User/
9 lines
50 lines
31 lines
31 lines
30 lines
10 lines

Diff 8813

View Options

src/app/Console/Commands/User/DomainsCommand.php

Loading...
View Options

src/app/Console/Commands/User/GroupsCommand.php

Loading...
View Options

src/app/Console/Commands/User/ResourcesCommand.php

Loading...
View Options

src/app/Console/Commands/User/SharedFoldersCommand.php

Loading...
View Options

src/app/Console/Commands/User/UsersCommand.php

Loading...
View Options

src/app/Console/ObjectRelationListCommand.php

Loading...
View Options

src/app/Domain.php

Loading...
View Options

src/app/Http/Controllers/API/V4/DomainsController.php

Loading...
View Options

src/app/Http/Controllers/API/V4/UsersController.php

Loading...
View Options

src/app/Rules/GroupName.php

Loading...
View Options

src/app/Rules/ResourceName.php

Loading...
View Options

src/app/Rules/SharedFolderName.php

Loading...
View Options

src/app/User.php

Loading...
View Options

src/tests/Feature/Console/User/DomainsTest.php

Loading...
View Options

src/tests/Feature/Console/User/GroupsTest.php

Loading...
View Options

src/tests/Feature/Console/User/ResourcesTest.php

Loading...
View Options

src/tests/Feature/Console/User/SharedFoldersTest.php

Loading...
View Options

src/tests/Feature/Console/User/UsersTest.php

Loading...
View Options

src/tests/Feature/UserTest.php

Loading...