Details
- Reviewers
- None
- Group Reviewers
Roundcube Kolab Plugins Developers
Diff Detail
- Repository
- rRPK roundcubemail-plugins-kolab
- Branch
- patch/T2040
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 7038 Build 7188: arc lint + arc unit
Event Timeline
Looks like this bug only happens in the old version. The most recent plugins package from Winterfell doesn't have this issue
So I guess this patch isn't really needed. I guess the call for manticore_api is some kind of fallback.
I don't think we should imitate the editor api if any of manticore_api nor document_editor_api exists. If that happens it's an error anyway. Actually I can think only about one case, the chwala javascript file didn't load. As you can see in https://git.kolab.org/rRPK7adf82a0c6a0b272af8847dedd4b912312141f0e loading the manticore_api was never conditional.
yeah I'm okay with this. I guess it was only a situation where packages were combined in Kolab:16 that didn't played well together. With the upcoming package updates it will be gone.