Page MenuHomePhorge

T2040: Don't call manticore_api when it's not loaded
AbandonedPublic

Authored by dhoffend on Dec 4 2016, 11:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 4:25 PM
Unknown Object (File)
Feb 13 2024, 7:50 AM
Unknown Object (File)
Dec 31 2023, 5:21 PM
Unknown Object (File)
Dec 5 2023, 3:38 PM
Unknown Object (File)
Nov 15 2023, 5:10 PM
Unknown Object (File)
Oct 27 2023, 9:14 AM
Unknown Object (File)
Oct 5 2023, 12:47 PM
Unknown Object (File)
Oct 5 2023, 7:22 AM
Subscribers

Details

Reviewers
None
Group Reviewers
Roundcube Kolab Plugins Developers

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Branch
patch/T2040
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 7038
Build 7188: arc lint + arc unit

Event Timeline

dhoffend retitled this revision from to T2040: Don't call manticore_api when it's not loaded.
dhoffend updated this object.
dhoffend edited the test plan for this revision. (Show Details)

Looks like this bug only happens in the old version. The most recent plugins package from Winterfell doesn't have this issue
So I guess this patch isn't really needed. I guess the call for manticore_api is some kind of fallback.

machniak subscribed.

I don't think we should imitate the editor api if any of manticore_api nor document_editor_api exists. If that happens it's an error anyway. Actually I can think only about one case, the chwala javascript file didn't load. As you can see in https://git.kolab.org/rRPK7adf82a0c6a0b272af8847dedd4b912312141f0e loading the manticore_api was never conditional.

yeah I'm okay with this. I guess it was only a situation where packages were combined in Kolab:16 that didn't played well together. With the upcoming package updates it will be gone.