Details
Details
- Reviewers
machniak - Group Reviewers
Restricted Project
Diff Detail
Diff Detail
- Repository
- rK kolab
- Branch
- arcpatch-D2137_1
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 33754 Build 13363: arc lint + arc unit
Event Timeline
src/app/Entitlement.php | ||
---|---|---|
84 | Missing space. | |
src/app/Transaction.php | ||
49 | Missing space. | |
src/app/Wallet.php | ||
98 | Removed line that should not be removed. | |
src/database/migrations/2021_01_14_093842_add_timespan_to_transactions_table.php | ||
19 |
| |
31 | Missing drop column statements. | |
src/resources/vue/Widgets/TransactionLog.vue | ||
114 | Missing space. | |
115 | I think we should use Laravel's type casting https://laravel.com/docs/6.x/eloquent-mutators#date-casting |
Comment Actions
And of course some tests will be needed.
src/resources/vue/Widgets/TransactionLog.vue | ||
---|---|---|
118 | What if this is the same day? Should we display that differently? Should we display additional "X days" text? |
src/app/Entitlement.php | ||
---|---|---|
81 | Missing documentation for the added arguments. | |
src/app/Transaction.php | ||
19 | Please, document 'period_start' and 'period_end' properties here. | |
src/database/migrations/2021_01_14_093842_add_timespan_to_transactions_table.php | ||
19 | Not done. The column names are wrong. Also, what happens with the existing records? I think it should be nullable() instead of useCurrent(). | |
src/resources/vue/Widgets/TransactionLog.vue | ||
114 | Not done. Missing space after if. |