Added KEP:14 support for parsing vacation scripts
char* -> QLatin1String
Added tests for VacationParser
parse new vacation script
Make create vacation ready for KEP:14
Added kill feature and cleanup destructure
show correct vacation status
Details
Details
- Reviewers
mollekopf - Maniphest Tasks
- T200: make kontact and roundcubemail use the same sieve logic for out of office
T199: Sieve KEP:14
T198: Make sieve editor KEP:14 comaptible - Commits
- rKP30c20931379a: parse new vacation script
rKPc0166215bd66: Support KEP:14 in sieveeditor
rKP94cb8575a11c: show correct vacation status
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Wow, quite the patch.
It's a bit scary how much code is required to achieve a seemingly not overly difficult task, but I'll just assume the reason is the existing codebase.
Good work if it works! ;-)
| libksieve/ksieveui/managescriptsjob/checkkep14supportjob.cpp | ||
|---|---|---|
| 29 | I think this should really be a KJob. For the next time. | |