Paths

Table of Contentst

Differential D2122

Pass on a language identifier even if we couldn't find a translation file
ClosedPublic
Actions

Authored by mollekopf on Jan 18 2021, 1:07 PM.

Tags

None

Referenced Files

	F12030993: D2122.id5857.diff
	Mon, May 6, 3:06 PM

	Unknown Object (File)
	Mon, May 6, 8:55 AM

	Unknown Object (File)
	Sat, May 4, 2:55 PM

	Unknown Object (File)
	Fri, May 3, 4:44 PM

	Unknown Object (File)
	Sat, Apr 13, 8:30 PM

	Unknown Object (File)
	Tue, Apr 9, 8:40 PM

	Unknown Object (File)
	Mon, Apr 8, 7:32 AM

	Unknown Object (File)
	Apr 3 2024, 7:42 PM

View All 38 Files

Subscribers

None

Details

Reviewers

Group Reviewers

Chwala Developers

Commits

rCaacc7c613626: Pass on a language identifier even if we couldn't find a translation file

Summary

This fixes translating the collabora online UI for languages other than
german and english.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mollekopf requested review of this revision.Jan 18 2021, 1:07 PM

mollekopf created this revision.

Harbormaster completed remote builds in B32713: Diff 5842.Jan 18 2021, 1:07 PM

mollekopf added reviewers: Chwala Developers, machniak.Jan 18 2021, 1:08 PM

machniak added inline comments.Jan 18 2021, 1:21 PM

lib/file_locale.php
107	It is probably all right. These three lines are already executed in this file, so I see a room for improvement. I.e. set $fallback in the foreach loop above. Also, add space after `//`.

Addressed comments

Harbormaster completed remote builds in B32719: Diff 5848.Jan 18 2021, 1:28 PM

machniak accepted this revision.Jan 18 2021, 1:29 PM

This revision is now accepted and ready to land.Jan 18 2021, 1:29 PM

Closed by commit rCaacc7c613626: Pass on a language identifier even if we couldn't find a translation file (authored by mollekopf). · Explain WhyJan 18 2021, 1:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

lib/

file_locale.php

9 lines

Diff 5857

lib/file_locale.php

Loading...