Page MenuHomePhorge
Differential D1846

Improvements and fixes to stats
ClosedPublic
Actions

Authored by machniak on Nov 13 2020, 1:22 PM.
Tags
None
Referenced Files
F12030948: D1846.id.diff
Mon, May 6, 3:01 PM
Unknown Object (File)
Tue, Apr 9, 1:54 PM
Unknown Object (File)
Apr 5 2024, 11:48 PM
Unknown Object (File)
Apr 5 2024, 7:05 AM
Unknown Object (File)
Mar 11 2024, 8:59 PM
Unknown Object (File)
Feb 10 2024, 1:43 AM
Unknown Object (File)
Jan 29 2024, 11:21 PM
Unknown Object (File)
Jan 16 2024, 3:34 AM
View All 23 Files
Subscribers
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rKad141453d2fd: Improvements and fixes to stats
Summary
  • npm update
  • Limit Discounts chart data to existing accounts
  • Simplify pluck() use
  • Use date_format() instead of week() to get week number with a leading zero
  • Display an average value
  • Added tests for stats

Diff Detail

Repository
rK kolab
Branch
dev/stats-fixes
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 31828
Build 12121: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Nov 13 2020, 1:22 PM
machniak created this revision.
Harbormaster completed remote builds in B31828: Diff 5110.Nov 13 2020, 1:22 PM
vanmeeuwen accepted this revision.Nov 20 2020, 10:22 AM
This revision is now accepted and ready to land.Nov 20 2020, 10:22 AM
Closed by commit rKad141453d2fd: Improvements and fixes to stats (authored by machniak, committed by vanmeeuwen). · Explain WhyNov 20 2020, 10:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
bin/
2 lines
src/
app/
Http/
Controllers/
API/
V4/
Admin/
26 lines
2072 lines
8 lines
tests/
Browser/
Admin/
45 lines
Pages/
Admin/
44 lines
Feature/
Controller/
Admin/
88 lines

Diff 5110

View Options

bin/phpstan

Loading...
View Options

src/app/Http/Controllers/API/V4/Admin/StatsController.php

Loading...
View Options

src/package-lock.json

Loading...
View Options

src/package.json

Loading...
View Options

src/tests/Browser/Admin/StatsTest.php

Loading...
View Options

src/tests/Browser/Pages/Admin/Stats.php

Loading...
View Options

src/tests/Feature/Controller/Admin/StatsTest.php

Loading...