Differential D1468
Protect against a 0-length for parameters as well. Authored by mollekopf on Aug 11 2020, 9:34 AM. Tags None Referenced Files
Subscribers None
Details
Encountered with a tag of 0 (attachmentname), but that might be Since this is not treated above as an error, I'm not treating it as one
Diff Detail
Event TimelineComment Actions It's not quite clear to me how simply ignoring if the stream is at the end is a valid error handling strategy (it seems we aren't buffering the existing data, so it would be lost?), but if it's acceptable for the properties above I suppose it is ok here too. @machniak Maybe you know more about what guarantees we do and don't have, and if we should turn all of the 0-length occurrences into errors. (I don't suppose with http we can receive part of a command?) Comment Actions I guess we could also check the result of the first fread($stream, 1), but I think the proposed change is good enough. |