Page MenuHomePhorge
Differential D1366

Fix transaction description for domain entitlements
ClosedPublic
Actions

Authored by machniak on Jun 11 2020, 9:16 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 5:58 PM
Unknown Object (File)
Thu, May 2, 5:49 PM
Unknown Object (File)
Thu, May 2, 4:41 AM
Unknown Object (File)
Sat, Apr 27, 4:57 AM
Unknown Object (File)
Sun, Apr 7, 10:42 AM
Unknown Object (File)
Apr 5 2024, 2:46 PM
Unknown Object (File)
Apr 3 2024, 8:29 PM
Unknown Object (File)
Mar 28 2024, 3:26 PM
View All 32 Files
Subscribers
vanmeeuwen
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK037514191beb: Fix transaction description for domain entitlements
Summary
  • Fixed the bug
  • Refactored code for better performance
  • Moved user_email setting to the observer
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/transaction-desc
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 29824
Build 11035: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jun 11 2020, 9:16 AM
machniak created this revision.
Harbormaster completed remote builds in B29824: Diff 3634.Jun 11 2020, 9:16 AM
machniak edited the summary of this revision. (Show Details)Jun 11 2020, 9:20 AM
vanmeeuwen requested changes to this revision.Jun 15 2020, 2:53 PM
vanmeeuwen subscribed.

One question for the whodunnit.

This revision now requires changes to proceed.Jun 15 2020, 2:53 PM
vanmeeuwen added a comment.Jun 15 2020, 2:56 PM

With question ;-)

src/app/Entitlement.php
87

Why would we not include the whodunnit here?

vanmeeuwen accepted this revision.Jun 15 2020, 2:59 PM
This revision is now accepted and ready to land.Jun 15 2020, 2:59 PM
Closed by commit rK037514191beb: Fix transaction description for domain entitlements (authored by machniak). · Explain WhyJun 15 2020, 3:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
Commands/
3 lines
17 lines
Observers/
4 lines
157 lines
2 lines
resources/
lang/
en/
20 lines
tests/
Unit/
184 lines

Diff 3634

View Options

src/app/Console/Commands/WalletTransactions.php

Loading...
View Options

src/app/Entitlement.php

Loading...
View Options

src/app/Observers/TransactionObserver.php

Loading...
View Options

src/app/Transaction.php

Loading...
View Options

src/app/Wallet.php

Loading...
View Options

src/resources/lang/en/transactions.php

Loading...
View Options

src/tests/Unit/TransactionTest.php

Loading...