Differential D1213

T332912: Users table cleanup
ClosedPublic
Actions

Authored by machniak on Apr 19 2020, 12:23 PM.

Details

Reviewers

vanmeeuwen

Group Reviewers

Restricted Project

Commits

rK6a3838a7f700: T332912: Users table cleanup

Summary

Removed users.name and users.email_verified_at
Keep the rest of user props as UserSetting
Add Organization field to user Profile page
Signup asks for first and last name separately instead of a name only.

Fix tests with Laravel 6.18.8, use PHPUnit 8

Test Plan

./phpunit

Diff Detail

Repository

rK kolab

Branch

dev/name-cleanup

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 29254
Build 10633: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Apr 19 2020, 12:23 PM

machniak created this revision.

Harbormaster completed remote builds in B29248: Diff 3124.Apr 19 2020, 12:23 PM

Don't invoke user update job on user setting that is not used by the backend
Add tests for User::name()

Harbormaster completed remote builds in B29254: Diff 3130.Apr 19 2020, 4:35 PM

vanmeeuwen accepted this revision.Apr 21 2020, 4:28 PM

This revision is now accepted and ready to land.Apr 21 2020, 4:28 PM

Closed by commit rK6a3838a7f700: T332912: Users table cleanup (authored by machniak). · Explain WhyApr 21 2020, 8:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

app/

Backends/

LDAP.php

11 lines

Http/

Controllers/

API/

SignupController.php

32 lines

V4/

PaymentsController.php

2 lines

UsersController.php

27 lines

Mail/

PasswordReset.php

2 lines

Observers/

UserObserver.php

35 lines

UserSettingObserver.php

44 lines

Traits/

UserSettingsTrait.php

4 lines

User.php

35 lines

composer.json

2 lines

database/

factories/

UserFactory.php

2 lines

migrations/

2014_10_12_000000_create_users_table.php

4 lines

seeds/

UserSeeder.php

11 lines

resources/

vue/

Admin/

User.vue

10 lines

Signup.vue

15 lines

User/

Info.vue

7 lines

Profile.vue

6 lines

tests/

Browser/

Admin/

22 lines

53 lines

26 lines

55 lines

Feature/

Backends/

LDAPTest.php

133 lines

Controller/

SignupTest.php

58 lines

UsersTest.php

7 lines

Jobs/

SignupVerificationEmailTest.php

3 lines

UserVerifyTest.php

20 lines

UserTest.php

116 lines

TestCase.php

1 line

Unit/

Mail/

PasswordResetTest.php

2 lines

Diff 3130

View Options

src/app/Backends/LDAP.php

View Options

src/app/Http/Controllers/API/SignupController.php

View Options

src/app/Http/Controllers/API/V4/PaymentsController.php

View Options

src/app/Http/Controllers/API/V4/UsersController.php

View Options

src/app/Mail/PasswordReset.php

View Options

src/app/Observers/UserObserver.php

View Options

src/app/Observers/UserSettingObserver.php

View Options

src/app/Traits/UserSettingsTrait.php

View Options

src/app/User.php

View Options

src/composer.json

View Options

src/database/factories/UserFactory.php

View Options

src/database/migrations/2014_10_12_000000_create_users_table.php

View Options

src/database/seeds/UserSeeder.php

View Options

src/resources/vue/Admin/User.vue

View Options

src/resources/vue/Signup.vue

View Options

src/resources/vue/User/Info.vue

View Options

src/resources/vue/User/Profile.vue

View Options

src/tests/Browser/Admin/UserTest.php

View Options

src/tests/Browser/SignupTest.php

View Options

src/tests/Browser/UserProfileTest.php

View Options

src/tests/Browser/UsersTest.php

View Options

src/tests/Feature/Backends/LDAPTest.php

View Options

src/tests/Feature/Controller/SignupTest.php

View Options

src/tests/Feature/Controller/UsersTest.php

View Options

src/tests/Feature/Jobs/SignupVerificationEmailTest.php

View Options

src/tests/Feature/Jobs/UserVerifyTest.php

View Options

src/tests/Feature/UserTest.php

View Options

src/tests/TestCase.php

View Options

src/tests/Unit/Mail/PasswordResetTest.php

T332912: Users table cleanupClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3130

src/app/Backends/LDAP.php

src/app/Http/Controllers/API/SignupController.php

src/app/Http/Controllers/API/V4/PaymentsController.php

src/app/Http/Controllers/API/V4/UsersController.php

src/app/Mail/PasswordReset.php

src/app/Observers/UserObserver.php

src/app/Observers/UserSettingObserver.php

src/app/Traits/UserSettingsTrait.php

src/app/User.php

src/composer.json

src/database/factories/UserFactory.php

src/database/migrations/2014_10_12_000000_create_users_table.php

src/database/seeds/UserSeeder.php

src/resources/vue/Admin/User.vue

src/resources/vue/Signup.vue

src/resources/vue/User/Info.vue

src/resources/vue/User/Profile.vue

src/tests/Browser/Admin/UserTest.php

src/tests/Browser/SignupTest.php

src/tests/Browser/UserProfileTest.php

src/tests/Browser/UsersTest.php

src/tests/Feature/Backends/LDAPTest.php

src/tests/Feature/Controller/SignupTest.php

src/tests/Feature/Controller/UsersTest.php

src/tests/Feature/Jobs/SignupVerificationEmailTest.php

src/tests/Feature/Jobs/UserVerifyTest.php

src/tests/Feature/UserTest.php

src/tests/TestCase.php

src/tests/Unit/Mail/PasswordResetTest.php

T332912: Users table cleanup
ClosedPublic
Actions

Revision Contents
Changeset List