A recurrenting event can be edited differntly (only this occurence, all occurences, thisandfuture).
We need to ask the user, what he wants to edit exactly.
Details
Diff Detail
- Repository
- rKP kdepim
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 3492 Build 3467: arc lint + arc unit
Event Timeline
korganizer/koeventpopupmenu.cpp | ||
---|---|---|
149 | This seems to break isLastOccurrence just below? We're trying to figure out if qd is the last occurrence by getting the next one, with your change you just get the same occurrence again? const KDateTime thisDateTime = inc->recurrence->getNextDateTime(qd.addDays(-1), QTime(23,59,59), CalendarSupport::KCalPrefs::instance()->timeSpec() )); On the first line so you end up calling getNextDateTime twice for isLastOccurrence and isFirstOccurrence. |
korganizer/koeventpopupmenu.cpp | ||
---|---|---|
149 | Well in this case it does not matter much because we only test !( isFirstOccurrence && isLastOccurrence ), that is only true for an item that is not a recurrenting one. But yes better fix the code, because it will be copied around :D |