Page MenuHomePhorge

Make sure imaplib exception argument is a string before using split() (#5387)
ClosedPublic

Authored by machniak on Apr 18 2016, 2:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 11, 1:44 AM
Unknown Object (File)
Sun, Jun 9, 11:11 AM
Unknown Object (File)
Sun, Jun 9, 10:41 AM
Unknown Object (File)
Wed, May 29, 10:36 AM
Unknown Object (File)
Tue, May 28, 12:28 AM
Unknown Object (File)
Thu, May 23, 2:07 PM
Unknown Object (File)
Tue, May 21, 4:46 AM
Unknown Object (File)
Sat, May 18, 11:31 PM
Subscribers
None

Details

Summary

Looks like imaplib in some conditions can throw exceptions without the message or
the message is not a string. We'll cast to string before using split() to prevent from
"AttributeError: 'int' object has no attribute 'split'" errors.

Diff Detail

Repository
rP pykolab
Branch
dev/5387
Lint
Lint Errors
SeverityLocationCodeMessage
Errorcyruslib.py:25E201PEP8 E201
Errorcyruslib.py:25E202PEP8 E202
Errorcyruslib.py:32E402PEP8 E402
Errorcyruslib.py:43E203PEP8 E203
Errorcyruslib.py:44E203PEP8 E203
Errorcyruslib.py:44E261PEP8 E261
Errorcyruslib.py:45E203PEP8 E203
Errorcyruslib.py:45E261PEP8 E261
Errorcyruslib.py:48E203PEP8 E203
Errorcyruslib.py:54E221PEP8 E221
Errorcyruslib.py:55E221PEP8 E221
Errorcyruslib.py:57E221PEP8 E221
Errorcyruslib.py:58E221PEP8 E221
Errorcyruslib.py:59E221PEP8 E221
Errorcyruslib.py:60E221PEP8 E221
Errorcyruslib.py:63E302PEP8 E302
Errorcyruslib.py:66E302PEP8 E302
Errorcyruslib.py:69E302PEP8 E302
Errorcyruslib.py:72E302PEP8 E302
Errorcyruslib.py:76E701PEP8 E701
Errorcyruslib.py:79E266PEP8 E266
Errorcyruslib.py:80E266PEP8 E266
Errorcyruslib.py:81E302PEP8 E302
Errorcyruslib.py:83E261PEP8 E261
Errorcyruslib.py:88E701PEP8 E701
Unit
No Test Coverage
Build Status
Buildable 3412
Build 3387: arc lint + arc unit

Event Timeline

machniak retitled this revision from to Make sure imaplib exception argument is a string before using split() (#5387).
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)
machniak added a reviewer: PyKolab Developers.
This revision is now accepted and ready to land.May 4 2016, 3:55 PM
This revision was automatically updated to reflect the committed changes.