Page MenuHomePhorge
Differential D1018

Get rid of owner_id
ClosedPublic
Actions

Authored by machniak on Mar 13 2020, 1:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 5:04 AM
Unknown Object (File)
Tue, Apr 9, 4:42 AM
Unknown Object (File)
Mon, Apr 8, 1:13 AM
Unknown Object (File)
Mar 31 2024, 1:35 PM
Unknown Object (File)
Mar 29 2024, 5:40 AM
Unknown Object (File)
Mar 28 2024, 3:30 AM
Unknown Object (File)
Feb 25 2024, 8:01 AM
Unknown Object (File)
Jan 19 2024, 5:09 PM
View All 32 Files
Subscribers
None

Details

Reviewers
vanmeeuwen
Commits
rK8ca5c29a3cc4: Get rid of owner_id
Summary

Removed entitlements.owner_id column and Entitlement::owner()

Diff Detail

Repository
rK kolab
Branch
dev/remove-owner-id
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 28552
Build 10246: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Mar 13 2020, 1:28 PM
machniak created this revision.
Harbormaster completed remote builds in B28552: Diff 2578.Mar 13 2020, 1:28 PM
vanmeeuwen requested changes to this revision.Mar 13 2020, 1:46 PM
vanmeeuwen added inline comments.
src/app/Entitlement.php
74

I think the function owner() may be preserved yet changed, similar to how App\Domain::wallet() chases the domain through the entitlement to a wallet.

This revision now requires changes to proceed.Mar 13 2020, 1:46 PM
machniak added inline comments.Mar 13 2020, 2:15 PM
src/app/Entitlement.php
74

I don't want to make it that simple, so we push ourselvs to think wallets not owners. There's really no need to have it as it would simply be $this->wallet()->owner.

vanmeeuwen accepted this revision.Mar 13 2020, 3:01 PM
This revision is now accepted and ready to land.Mar 13 2020, 3:01 PM
Closed by commit rK8ca5c29a3cc4: Get rid of owner_id (authored by machniak). · Explain WhyMar 13 2020, 3:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
8 lines
11 lines
Observers/
15 lines
21 lines
database/
migrations/
2 lines
tests/
Feature/
3 lines
Controller/
2 lines
9 lines
6 lines

Diff 2578

View Options

src/app/Domain.php

Loading...
View Options

src/app/Entitlement.php

Loading...
View Options

src/app/Observers/EntitlementObserver.php

Loading...
View Options

src/app/User.php

Loading...
View Options

src/database/migrations/2019_09_17_102628_create_sku_entitlements.php

Loading...
View Options

src/tests/Feature/BillingTest.php

Loading...
View Options

src/tests/Feature/Controller/DomainsTest.php

Loading...
View Options

src/tests/Feature/EntitlementTest.php

Loading...
View Options

src/tests/Feature/UserTest.php

Loading...