Page MenuHomePhorge
Differential D895

encode_page_control() must have a 2nd argument T5734
ClosedPublic
Actions

Authored by dhoffend on Dec 22 2019, 9:53 PM.
Tags
None
Referenced Files
F12882663: D895.id2068.diff
Mon, Jun 17, 1:34 AM
F12869364: D895.diff
Sun, Jun 16, 9:19 AM
Unknown Object (File)
Wed, Jun 12, 7:58 PM
Unknown Object (File)
Tue, Jun 11, 12:17 PM
Unknown Object (File)
Tue, Jun 11, 5:32 AM
Unknown Object (File)
Mon, Jun 10, 9:55 PM
Unknown Object (File)
Sat, Jun 8, 1:58 PM
Unknown Object (File)
Mon, May 27, 12:56 AM
View All 56 Files
Subscribers
None

Details

Reviewers
vanmeeuwen
Group Reviewers
PyKolab Developers
Commits
rP0e66fae6ac8c: encode_page_control() must have a 2nd argument T5734
Summary

As reported in T5734 kolab sync and kolabd are crashing
with a trackback that encode_page_control must have 2 arguments. Adding
the empty cookie attribute to the server_page_controls removed the error.

Diff Detail

Repository
rP pykolab
Branch
page_control
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27553
Build 9820: arc lint + arc unit

Event Timeline

dhoffend requested review of this revision.Dec 22 2019, 9:53 PM
dhoffend created this revision.
Harbormaster completed remote builds in B27547: Diff 2038.Dec 22 2019, 9:53 PM
dhoffend updated this revision to Diff 2044.Dec 23 2019, 6:30 PM
  • fix check for page control result
Harbormaster completed remote builds in B27553: Diff 2044.Dec 23 2019, 6:30 PM
dhoffend added a comment.Dec 23 2019, 6:31 PM

Hope this is correct from the documentation and examples about ldap paging search

vanmeeuwen accepted this revision.Jan 13 2020, 2:06 PM
This revision is now accepted and ready to land.Jan 13 2020, 2:06 PM
Closed by commit rP0e66fae6ac8c: encode_page_control() must have a 2nd argument T5734 (authored by dhoffend, committed by vanmeeuwen). · Explain WhyJan 13 2020, 2:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
pykolab/
auth/
ldap/
4 lines

Diff 2044

View Options

pykolab/auth/ldap/__init__.py

Loading...