Page MenuHomePhorge
Differential D895

encode_page_control() must have a 2nd argument T5734
ClosedPublic
Actions

Authored by dhoffend on Dec 22 2019, 9:53 PM.
Tags
None
Referenced Files
F11893320: D895.diff
Thu, Apr 25, 8:13 AM
Unknown Object (File)
Wed, Apr 24, 3:33 PM
Unknown Object (File)
Tue, Apr 9, 4:18 PM
Unknown Object (File)
Tue, Apr 9, 3:13 PM
Unknown Object (File)
Sun, Apr 7, 2:53 PM
Unknown Object (File)
Wed, Apr 3, 6:33 PM
Unknown Object (File)
Fri, Mar 29, 10:00 PM
Unknown Object (File)
Mar 24 2024, 11:29 AM
View All 41 Files
Subscribers
None

Details

Reviewers
vanmeeuwen
Group Reviewers
PyKolab Developers
Commits
rP0e66fae6ac8c: encode_page_control() must have a 2nd argument T5734
Summary

As reported in T5734 kolab sync and kolabd are crashing
with a trackback that encode_page_control must have 2 arguments. Adding
the empty cookie attribute to the server_page_controls removed the error.

Diff Detail

Repository
rP pykolab
Branch
page_control
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 27547
Build 9814: arc lint + arc unit

Event Timeline

dhoffend requested review of this revision.Dec 22 2019, 9:53 PM
dhoffend created this revision.
Harbormaster completed remote builds in B27547: Diff 2038.Dec 22 2019, 9:53 PM
dhoffend updated this revision to Diff 2044.Dec 23 2019, 6:30 PM
  • fix check for page control result
Harbormaster completed remote builds in B27553: Diff 2044.Dec 23 2019, 6:30 PM
dhoffend added a comment.Dec 23 2019, 6:31 PM

Hope this is correct from the documentation and examples about ldap paging search

vanmeeuwen accepted this revision.Jan 13 2020, 2:06 PM
This revision is now accepted and ready to land.Jan 13 2020, 2:06 PM
Closed by commit rP0e66fae6ac8c: encode_page_control() must have a 2nd argument T5734 (authored by dhoffend, committed by vanmeeuwen). · Explain WhyJan 13 2020, 2:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
pykolab/
auth/
ldap/
2 lines

Diff 2038

View Options

pykolab/auth/ldap/__init__.py

Loading...