Page MenuHomePhorge
Differential D737

fix return value of init_ldap()
ClosedPublic
Actions

Authored by dhoffend on Apr 9 2019, 11:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 17, 9:06 AM
Unknown Object (File)
Wed, May 15, 11:41 AM
Unknown Object (File)
Fri, May 10, 8:43 AM
Unknown Object (File)
Fri, May 10, 6:31 AM
Unknown Object (File)
Sun, May 5, 3:30 AM
Unknown Object (File)
Sat, Apr 27, 5:36 AM
Unknown Object (File)
Tue, Apr 23, 6:46 PM
Unknown Object (File)
Sat, Apr 20, 7:54 AM
View All 44 Files
Subscribers
None

Details

Reviewers
machniak
vanmeeuwen
Commits
rACbbd4949ef530: fix return value of init_ldap()
Summary

init_ldap doesn't return true on success

autoconf doesn't lookup the username in ldap because init_ldap() always returns
null, but get_user() expects a non-false response.

Diff Detail

Repository
rAC autoconf
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 23558
Build 9572: arc lint + arc unit

Event Timeline

dhoffend requested review of this revision.Apr 9 2019, 11:51 PM
dhoffend created this revision.
Harbormaster completed remote builds in B23558: Diff 1679.Apr 9 2019, 11:51 PM
machniak accepted this revision.Apr 10 2019, 8:26 AM

That's a bug introduced by e544905221b and the fix makes sense.

This revision is now accepted and ready to land.Apr 10 2019, 8:26 AM
Closed by commit rACbbd4949ef530: fix return value of init_ldap() (authored by dhoffend, committed by machniak). · Explain WhyApr 10 2019, 12:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
lib/
4 lines

Diff 1679

View Options

lib/Autodiscover.php

Loading...