With some small code cleanup in tests
Details
Details
- Reviewers
mollekopf - Group Reviewers
Restricted Project - Commits
- rKeb9ce8833157: To refresh a token only a refresh token should be needed
./phpunit
Diff Detail
Diff Detail
- Repository
- rK kolab
- Branch
- dev/token-refresh-fix
- Lint
Lint Skipped - Unit
No Test Coverage - Build Status
Buildable 55986 Build 19851: arc lint + arc unit
Event Timeline
Comment Actions
Looks tidy =) A clarification on the user retrieval magic would help, otherwise that seems good to go.
| src/app/Http/Controllers/API/AuthController.php | ||
|---|---|---|
| 193 | I don't really follow why this->guard()->user() doesn't work here (maybe because this is called with the refresh token instead of the user token?), and retrieving it via event listener does look surpristing, so a clarifying comment might help: e.g. The token refresh is using a refresh token instead of an access toke, in which case this->guard()->user() doesn't work. We listen for the newly refreshed token, so we can resolve the user that is then used to directly return user-info in this request. | |