blocking depending on config option, so we can first mark as blocked,
and only start blocking in a second step.
Details
Details
- Reviewers
machniak - Group Reviewers
Syncroton Developers - Commits
- rSf90fc266ba35: Mark devices as broken
Diff Detail
Diff Detail
- Repository
- rS syncroton
- Branch
- master
- Lint
Lint Skipped - Unit
No Test Coverage - Build Status
Buildable 54447 Build 19341: arc lint + arc unit
Event Timeline
Comment Actions
My plan is to deploy this, review which devices get marked as broken, and only then start failing requests early.
Comment Actions
I don't see how you unset the "broken" state. You said that when you reset Outlook according to your manual it will use the same device identifier. How it will unlock itself then? A test would be nice.
| docs/SQL/mysql.initial.sql | ||
|---|---|---|
| 35 | How about make broken is_broken and store the details in extra_data? | |
| lib/ext/Syncroton/Command/FolderSync.php | ||
| 131 | If device is already broken I would skip the update. This way we'd know since when it's broken. | |
Comment Actions
This is how outlook looks once we block the device (as you can see it enters "Disconnected/Getrennt" state).
Comment Actions
is_broken would be better because we already have is_deleted in some tables, but fine.