Ignore the imap subscription state for activesync folders
ClosedPublic
Actions

Authored by mollekopf on Jun 12 2025, 10:06 AM.

Project Tags

None

Referenced Files

	F117859217: D5352.1775318179.diff
	Fri, Apr 3, 3:56 PM

	F117854570: D5352.1775315692.diff
	Fri, Apr 3, 3:14 PM

	F117778637: D5352.1775244922.diff
	Thu, Apr 2, 7:35 PM

	F117415548: D5352.1774829984.diff
	Sun, Mar 29, 12:19 AM

	F117366741: D5352.1774816800.diff
	Sat, Mar 28, 8:40 PM

Subscribers

Details

Reviewers

machniak

Group Reviewers

Roundcube Kolab Plugins Developers

Commits

Repository

rRPK roundcubemail-plugins-kolab

Branch

master

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 54132
Build 19206: arc lint + arc unit

mollekopf requested review of this revision.Jun 12 2025, 10:06 AM

mollekopf created this revision.

not tested yet

machniak requested changes to this revision.Jun 12 2025, 10:09 AM

machniak subscribed.

machniak added inline comments.

plugins/libkolab/lib/kolab_subscriptions.php
93	This code branch is for Kolab4 and for mail folders only. I would not change this here.
100	We need to replace `true` with `false` (or `null`) here.

This revision now requires changes to proceed.Jun 12 2025, 10:09 AM

mollekopf marked 2 inline comments as done.Jun 12 2025, 10:13 AM

mollekopf added inline comments.

plugins/libkolab/lib/kolab_subscriptions.php
93	I would change this anyways, so the behavior is consistent. I don't think having two layers of configuration really helps (first imap subscription, then activesync), so I'm for ignoring subscriptions here too. Do you have a reason not to?