Page MenuHomePhorge
Differential D4944

User impersonation support in IMAP data migrator
ClosedPublic
Actions

Authored by machniak on Sep 17 2024, 1:31 PM.

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK47a61c0239c5: User impersonation support in IMAP data migrator

Diff Detail

Repository
rK kolab
Branch
dev/imap-impersonation
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 50361
Build 18402: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Sep 17 2024, 1:31 PM
machniak created this revision.
Harbormaster completed remote builds in B50358: Diff 14163.Sep 17 2024, 1:31 PM
mollekopf accepted this revision.Sep 17 2024, 1:35 PM
This revision is now accepted and ready to land.Sep 17 2024, 1:35 PM
machniak updated this revision to Diff 14166.Sep 17 2024, 1:52 PM
  • Unify the way user impersonation is configured in data migrator URIs
Harbormaster completed remote builds in B50361: Diff 14166.Sep 17 2024, 1:52 PM
Closed by commit rK47a61c0239c5: User impersonation support in IMAP data migrator. · Explain WhySep 18 2024, 1:41 PM
This revision was automatically updated to reflect the committed changes.
machniak added a commit: rK47a61c0239c5: User impersonation support in IMAP data migrator.

Revision Contents
Changeset List

PathSize
src/
app/
DataMigrator/
10 lines
27 lines
tests/
3 lines
Feature/
DataMigrator/
7 lines

Diff 14166

View Options

src/app/DataMigrator/Account.php

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
/* /*
* Parse XML, create KCalCore container and extract attachments * Parse XML, create KCalCore container and extract attachments
*/ */
template <typename KCalPtr, typename Container> template <typename KCalPtr, typename Container>
static KCalPtr fromXML(const QByteArray &xmlData, QStringList &attachments) static KCalPtr fromXML(const QByteArray &xmlData, QStringList &attachments)
{ {
const QDomDocument xmlDoc = KolabV2::KolabBase::loadDocument( QString::fromUtf8(xmlData) ); //TODO extract function from V2 format const QDomDocument xmlDoc = KolabV2::KolabBase::loadDocument( QString::fromUtf8(xmlData) ); //TODO extract function from V2 format
if ( xmlDoc.isNull() ) { if ( xmlDoc.isNull() ) {
Critical() << "Failed to read the xml document"; Error() << "Failed to read the xml document";
return KCalPtr(); return KCalPtr();
} }
const KCalPtr i = Container::fromXml( xmlDoc, QString() ); //For parsing we don't need the timezone, so we don't set one const KCalPtr i = Container::fromXml( xmlDoc, QString() ); //For parsing we don't need the timezone, so we don't set one
Q_ASSERT ( i ); Q_ASSERT ( i );
QDomNodeList nodes = xmlDoc.elementsByTagName("inline-attachment"); QDomNodeList nodes = xmlDoc.elementsByTagName("inline-attachment");
for (int i = 0; i < nodes.size(); i++ ) { for (int i = 0; i < nodes.size(); i++ ) {
attachments.append(nodes.at(i).toElement().text()); attachments.append(nodes.at(i).toElement().text());
} }
Show All 40 Lines
View Options

src/app/DataMigrator/IMAP.php

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
/* /*
* Parse XML, create KCalCore container and extract attachments * Parse XML, create KCalCore container and extract attachments
*/ */
template <typename KCalPtr, typename Container> template <typename KCalPtr, typename Container>
static KCalPtr fromXML(const QByteArray &xmlData, QStringList &attachments) static KCalPtr fromXML(const QByteArray &xmlData, QStringList &attachments)
{ {
const QDomDocument xmlDoc = KolabV2::KolabBase::loadDocument( QString::fromUtf8(xmlData) ); //TODO extract function from V2 format const QDomDocument xmlDoc = KolabV2::KolabBase::loadDocument( QString::fromUtf8(xmlData) ); //TODO extract function from V2 format
if ( xmlDoc.isNull() ) { if ( xmlDoc.isNull() ) {
Critical() << "Failed to read the xml document"; Error() << "Failed to read the xml document";
return KCalPtr(); return KCalPtr();
} }
const KCalPtr i = Container::fromXml( xmlDoc, QString() ); //For parsing we don't need the timezone, so we don't set one const KCalPtr i = Container::fromXml( xmlDoc, QString() ); //For parsing we don't need the timezone, so we don't set one
Q_ASSERT ( i ); Q_ASSERT ( i );
QDomNodeList nodes = xmlDoc.elementsByTagName("inline-attachment"); QDomNodeList nodes = xmlDoc.elementsByTagName("inline-attachment");
for (int i = 0; i < nodes.size(); i++ ) { for (int i = 0; i < nodes.size(); i++ ) {
attachments.append(nodes.at(i).toElement().text()); attachments.append(nodes.at(i).toElement().text());
} }
Show All 40 Lines
View Options

src/tests/BackendsTrait.php

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
/* /*
* Parse XML, create KCalCore container and extract attachments * Parse XML, create KCalCore container and extract attachments
*/ */
template <typename KCalPtr, typename Container> template <typename KCalPtr, typename Container>
static KCalPtr fromXML(const QByteArray &xmlData, QStringList &attachments) static KCalPtr fromXML(const QByteArray &xmlData, QStringList &attachments)
{ {
const QDomDocument xmlDoc = KolabV2::KolabBase::loadDocument( QString::fromUtf8(xmlData) ); //TODO extract function from V2 format const QDomDocument xmlDoc = KolabV2::KolabBase::loadDocument( QString::fromUtf8(xmlData) ); //TODO extract function from V2 format
if ( xmlDoc.isNull() ) { if ( xmlDoc.isNull() ) {
Critical() << "Failed to read the xml document"; Error() << "Failed to read the xml document";
return KCalPtr(); return KCalPtr();
} }
const KCalPtr i = Container::fromXml( xmlDoc, QString() ); //For parsing we don't need the timezone, so we don't set one const KCalPtr i = Container::fromXml( xmlDoc, QString() ); //For parsing we don't need the timezone, so we don't set one
Q_ASSERT ( i ); Q_ASSERT ( i );
QDomNodeList nodes = xmlDoc.elementsByTagName("inline-attachment"); QDomNodeList nodes = xmlDoc.elementsByTagName("inline-attachment");
for (int i = 0; i < nodes.size(); i++ ) { for (int i = 0; i < nodes.size(); i++ ) {
attachments.append(nodes.at(i).toElement().text()); attachments.append(nodes.at(i).toElement().text());
} }
Show All 40 Lines
View Options

src/tests/Feature/DataMigrator/IMAPTest.php

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
/* /*
* Parse XML, create KCalCore container and extract attachments * Parse XML, create KCalCore container and extract attachments
*/ */
template <typename KCalPtr, typename Container> template <typename KCalPtr, typename Container>
static KCalPtr fromXML(const QByteArray &xmlData, QStringList &attachments) static KCalPtr fromXML(const QByteArray &xmlData, QStringList &attachments)
{ {
const QDomDocument xmlDoc = KolabV2::KolabBase::loadDocument( QString::fromUtf8(xmlData) ); //TODO extract function from V2 format const QDomDocument xmlDoc = KolabV2::KolabBase::loadDocument( QString::fromUtf8(xmlData) ); //TODO extract function from V2 format
if ( xmlDoc.isNull() ) { if ( xmlDoc.isNull() ) {
Critical() << "Failed to read the xml document"; Error() << "Failed to read the xml document";
return KCalPtr(); return KCalPtr();
} }
const KCalPtr i = Container::fromXml( xmlDoc, QString() ); //For parsing we don't need the timezone, so we don't set one const KCalPtr i = Container::fromXml( xmlDoc, QString() ); //For parsing we don't need the timezone, so we don't set one
Q_ASSERT ( i ); Q_ASSERT ( i );
QDomNodeList nodes = xmlDoc.elementsByTagName("inline-attachment"); QDomNodeList nodes = xmlDoc.elementsByTagName("inline-attachment");
for (int i = 0; i < nodes.size(); i++ ) { for (int i = 0; i < nodes.size(); i++ ) {
attachments.append(nodes.at(i).toElement().text()); attachments.append(nodes.at(i).toElement().text());
} }
Show All 40 Lines