First attempt to get oauth going
ClosedPublic
Actions

Authored by mollekopf on Jul 17 2024, 2:12 PM.

Details

Reviewers

None

Group Reviewers

Restricted Project

Commits

rK8363ab18baad: OAuth2/OpenID Connect support with initial config for synapse

Summary

The problem seems to be that a session is expected for the authorization
page, but we're not using one, and therefore this fails.

Diff Detail

Repository

rK kolab

Branch

dev/mollekopf

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 48129
Build 18237: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Jul 17 2024, 2:12 PM

mollekopf created this revision.

Harbormaster completed remote builds in B48129: Diff 13902.Jul 17 2024, 2:12 PM

mollekopf retitled this revision from First attempt to get oauth going to OAuth for element/synapse.Jul 17 2024, 2:19 PM

mollekopf edited the summary of this revision. (Show Details)

mollekopf added a reviewer: Restricted Project.

mollekopf added a project: Restricted Project.

mollekopf added inline comments.Jul 17 2024, 2:42 PM

src/app/Providers/PassportServiceProvider.php
20	Moving these is not really necessary in this patch, but it seems like the right place for them.

Separate token scope

Harbormaster completed remote builds in B48135: Diff 13905.Jul 18 2024, 11:39 AM

Cleanup

Harbormaster completed remote builds in B48138: Diff 13908.Jul 18 2024, 11:50 AM

I'm going to write tests.

BTW, I noted that some of your differentials cannot be easily used. arc patch returns "Base commit is not in local repository". Then I get:

Checking patch docker/synapse/rootfs/opt/app-root/src/init.sh...
error: docker/synapse/rootfs/opt/app-root/src/init.sh: does not exist in index
Checking patch docker/synapse/rootfs/opt/app-root/src/homeserver.yaml...
error: docker/synapse/rootfs/opt/app-root/src/homeserver.yaml: does not exist in index
Checking patch docker/synapse/Dockerfile...
error: docker/synapse/Dockerfile: does not exist in index
Checking patch config.prod/src/database/seeds/PassportSeeder.php...
Checking patch config.demo/src/database/seeds/PassportSeeder.php...
Checking patch ci/testctl...
Hunk #1 succeeded at 111 (offset -1 lines).
Checking patch ci/env...
error: while searching for:
MEET_SERVER_TOKEN=simple123
PASSPORT_PROXY_OAUTH_CLIENT_ID=5909ca4f-df7e-45fe-b355-e7c195aef117
PASSPORT_PROXY_OAUTH_CLIENT_SECRET=3URb+3JGJM9wPuDnlUSTPOw2mqmHsoOV8NXanx9xwQM=
DES_KEY=kBxUM/53N9p9abusAoT0ZEAxwI2pxFz/

KOLAB_GIT_REF=master

error: patch failed: ci/env:151
Checking patch bin/podman_shared...
error: while searching for:

podman__run_synapse() {
    $PODMAN run -dt --pod $POD --name $POD-synapse --replace \
         $SYNAPSE_STORAGE \
        -e APP_DOMAIN \
        -e KOLAB_URL="http://127.0.0.1:8000" \
        synapse:latest
}


error: patch failed: bin/podman_shared:293

ok, I see https://git.kolab.org/rK0efac80d615b7c70f6d8edc168876aeaa867cf8c is missing.

machniak mentioned this in D4866: OAuth fixes and tests.Jul 29 2024, 2:29 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 5 2024, 10:50 PM

Closed by commit rK8363ab18baad: OAuth2/OpenID Connect support with initial config for synapse (authored by mollekopf). · Explain Why

This revision was automatically updated to reflect the committed changes.

mollekopf added a commit: rK8363ab18baad: OAuth2/OpenID Connect support with initial config for synapse.