Page MenuHomePhorge
Differential D4809

Turn the Receipt download into a ReceiptList
ClosedPublic
Actions

Authored by mollekopf on Fri, Jun 21, 12:38 PM.
Tags
None
Referenced Files
F13417134: D4809.diff
Mon, Jul 1, 5:59 AM
F13399413: D4809.id13770.diff
Mon, Jul 1, 1:37 AM
F13311075: D4809.diff
Sun, Jun 30, 7:52 AM
Unknown Object (File)
Sat, Jun 29, 8:37 PM
Unknown Object (File)
Sat, Jun 29, 3:24 PM
Unknown Object (File)
Sat, Jun 29, 12:40 PM
Unknown Object (File)
Fri, Jun 28, 10:47 PM
Unknown Object (File)
Fri, Jun 28, 9:29 PM
View All 22 Files
Subscribers
machniak

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKdb18f3b0086a: Turn the Receipt download into a ReceiptList

Diff Detail

Repository
rK kolab
Branch
dev/mollekopf
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 47784
Build 18141: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Fri, Jun 21, 12:38 PM
mollekopf created this revision.
Harbormaster completed remote builds in B47781: Diff 13761.Fri, Jun 21, 12:38 PM
mollekopf updated this revision to Diff 13764.Fri, Jun 21, 1:05 PM

Test, cleanup

Harbormaster completed remote builds in B47784: Diff 13764.Fri, Jun 21, 1:05 PM
mollekopf added a reviewer: Restricted Project.Fri, Jun 21, 1:05 PM
machniak requested changes to this revision.Fri, Jun 21, 1:20 PM
machniak subscribed.

Almost there. tests/Browser/WalletTest.php needs an update too.

src/resources/vue/Wallet.vue
145

downloadFile is not used anymore

src/resources/vue/Widgets/ReceiptList.vue
20

:colspan="3"

This revision now requires changes to proceed.Fri, Jun 21, 1:20 PM
mollekopf updated this revision to Diff 13767.Fri, Jun 21, 2:11 PM

Addressed comments

Harbormaster completed remote builds in B47787: Diff 13767.Fri, Jun 21, 2:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sat, Jun 22, 9:11 AM
Closed by commit rKdb18f3b0086a: Turn the Receipt download into a ReceiptList (authored by mollekopf). · Explain Why
This revision was automatically updated to reflect the committed changes.
mollekopf added a commit: rKdb18f3b0086a: Turn the Receipt download into a ReceiptList.

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
31 lines
resources/
vue/
25 lines
Widgets/
61 lines
tests/
Feature/
Controller/
2 lines

Diff 13764

View Options

src/app/Http/Controllers/API/V4/WalletsController.php

Loading...
View Options

src/resources/vue/Wallet.vue

Loading...
View Options

src/resources/vue/Widgets/ReceiptList.vue

Loading...
View Options

src/tests/Feature/Controller/WalletsTest.php

Loading...