Page MenuHomePhorge
Differential D4740

Improve domain:set-wallet
ClosedPublic
Actions

Authored by machniak on Jun 5 2024, 3:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 9:41 AM
Unknown Object (File)
Wed, Oct 30, 5:49 PM
Unknown Object (File)
Mon, Oct 28, 3:59 PM
Unknown Object (File)
Sun, Oct 27, 2:26 PM
Unknown Object (File)
Tue, Oct 22, 10:17 AM
Unknown Object (File)
Mon, Oct 21, 10:44 PM
Unknown Object (File)
Fri, Oct 18, 12:00 AM
Unknown Object (File)
Oct 16 2024, 10:20 PM
View All 51 Files
Subscribers
Restricted Project

Details

Reviewers
mollekopf
Group Reviewers
Restricted Project
Commits
rK2bf8d7f49f82: Improve domain:set-wallet
Summary

So it assigns a package instead of sku, same as DomainController does.

Test Plan

./phpunit tests/Feature/Console/Domain/SetWalletTest.php

Diff Detail

Repository
rK kolab
Branch
dev/domain-set-wallet-fix
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 47613
Build 18036: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jun 5 2024, 3:14 PM
machniak created this revision.
Harbormaster completed remote builds in B47613: Diff 13620.Jun 5 2024, 3:14 PM
mollekopf accepted this revision.Jun 11 2024, 10:21 AM
This revision is now accepted and ready to land.Jun 11 2024, 10:21 AM
Closed by commit rK2bf8d7f49f82: Improve domain:set-wallet (authored by machniak). · Explain WhyJun 11 2024, 12:43 PM
This revision was automatically updated to reflect the committed changes.
machniak added a commit: rK2bf8d7f49f82: Improve domain:set-wallet.

Revision Contents
Changeset List

PathSize
src/
app/
Console/
Commands/
Domain/
35 lines
tests/
Feature/
Console/
Domain/
11 lines

Diff 13620

View Options

src/app/Console/Commands/Domain/SetWalletCommand.php

Loading...
View Options

src/tests/Feature/Console/Domain/SetWalletTest.php

Loading...