Fold WalletCharge and WalletCheck into one
AbandonedPublic
Actions

Authored by mollekopf on Mon, Jun 3, 11:31 AM.

Details

Reviewers

None

Group Reviewers

Restricted Project

Diff Detail

Repository

rK kolab

Branch

dev/mollekopf

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 47544
Build 18018: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Mon, Jun 3, 11:31 AM

mollekopf created this revision.

Harbormaster completed remote builds in B47541: Diff 13581.Mon, Jun 3, 11:31 AM

Will require at least some more cleanup (remove WalletCharge job and command).

dispatch the right job

Harbormaster completed remote builds in B47544: Diff 13584.Mon, Jun 3, 11:33 AM

Maybe it makes sense, if huge number of jobs is not an issue. Also we should probably do dispatch($wallet->id) instead of dispatch($wallet) (and do find() instead of refresh()).

mollekopf planned changes to this revision.Tue, Jun 4, 2:25 PM

One more note. Currently if topUpWallet() throws exception (for any reason, e.g. Mollie connection issues) the WalletCharge job will try to top up the wallet again. Here it won't happen, so it will be more fragile to temporary issues with the payment provider. Catching the exception and invoking a separate WalletCharge job might make sense.

That means at least I wouldn't remove job:walletcharge command (and the job), it might come in handy.

machniak mentioned this in D4794: Fold WalletCharge and WalletCheck into one.Mon, Jun 17, 12:22 PM

See my take in D4794: Fold WalletCharge and WalletCheck into one

mollekopf abandoned this revision.Mon, Jun 24, 9:02 AM

machniak mentioned this in rK9f8438a620f3: Fold WalletCharge and WalletCheck into one.Mon, Jun 24, 2:54 PM