Page MenuHomePhorge
Differential D4424

Fix mail jobs retrying setup properties, unify
ClosedPublic
Actions

Authored by machniak on Jul 19 2023, 4:13 PM.
Tags
None
Referenced Files
F12871917: D4424.id12686.diff
Sun, Jun 16, 12:59 PM
F12864429: D4424.diff
Sun, Jun 16, 1:02 AM
Unknown Object (File)
Sat, Jun 15, 7:31 AM
Unknown Object (File)
Wed, Jun 5, 2:16 PM
Unknown Object (File)
Wed, Jun 5, 10:47 AM
Unknown Object (File)
Wed, Jun 5, 2:53 AM
Unknown Object (File)
Tue, Jun 4, 10:24 PM
Unknown Object (File)
Tue, Jun 4, 9:35 PM
View All Files
Subscribers
Restricted Project

Details

Reviewers
vanmeeuwen
Group Reviewers
Restricted Project
Commits
rK87398b587d3a: Fix mail jobs retrying setup properties, unify
Summary
  • removed retryUntil which was overriding $tries
  • added backoff interval
  • set tries/backoff to something more sensible and unified
  • renamed one occurrence of old v7 property name into a proper one
Test Plan

./phpunit

Diff Detail

Repository
rK kolab
Branch
dev/mail-jobs-retry-fix
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 43592
Build 17432: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Jul 19 2023, 4:13 PM
machniak created this revision.
Harbormaster completed remote builds in B43592: Diff 12686.Jul 19 2023, 4:13 PM
vanmeeuwen accepted this revision.Jul 31 2023, 1:42 PM
This revision is now accepted and ready to land.Jul 31 2023, 1:42 PM
Closed by commit rK87398b587d3a: Fix mail jobs retrying setup properties, unify (authored by machniak). · Explain WhyJul 31 2023, 2:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12686

View Options

src/app/Jobs/Password/RetentionEmailJob.php

Loading...
View Options

src/app/Jobs/PasswordResetEmail.php

Loading...
View Options

src/app/Jobs/PaymentEmail.php

Loading...
View Options

src/app/Jobs/PaymentMandateDisabledEmail.php

Loading...
View Options

src/app/Jobs/SignupVerificationEmail.php

Loading...
View Options

src/app/Jobs/SignupVerificationSMS.php

Loading...
View Options

src/app/Jobs/TrialEndEmail.php

Loading...