Page MenuHomePhorge
Differential D4145

Fix crash when checking for nonexistent handler.
ClosedPublic
Actions

Authored by mollekopf on Mar 11 2023, 12:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 26, 3:30 AM
Unknown Object (File)
Tue, Oct 22, 7:48 PM
Unknown Object (File)
Sep 13 2024, 8:39 AM
Unknown Object (File)
Sep 13 2024, 8:39 AM
Unknown Object (File)
Sep 10 2024, 6:58 PM
Unknown Object (File)
Sep 3 2024, 12:24 PM
Unknown Object (File)
Aug 30 2024, 4:05 AM
Unknown Object (File)
Aug 20 2024, 5:53 AM
View All 98 Files
Subscribers
None

Details

Reviewers
machniak
Group Reviewers
Restricted Project
Commits
rKcc4126d99e51: Fix crash when checking for nonexistent handler.
rKf618d2ae8f71: Fix crash when checking for nonexistent handler.
rK887975e5ff01: Fix crash when checking for nonexistent handler.
Summary

Required when creating a distlist, because we're looking for App\Handlers\Files.
Added warnings because it doesn't seem like it should normalyl occur.

Diff Detail

Repository
rK kolab
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41981
Build 16859: arc lint + arc unit

Event Timeline

mollekopf requested review of this revision.Mar 11 2023, 12:49 PM
mollekopf created this revision.
Harbormaster completed remote builds in B41981: Diff 11885.Mar 11 2023, 12:49 PM
mollekopf added a reviewer: Restricted Project.Mar 11 2023, 12:55 PM

I suppose some of this is just required because of php8.

machniak accepted this revision.Mar 13 2023, 12:04 PM
This revision is now accepted and ready to land.Mar 13 2023, 12:04 PM
Closed by commit rKcc4126d99e51: Fix crash when checking for nonexistent handler. (authored by mollekopf). · Explain WhyMar 22 2023, 10:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
app/
Http/
Controllers/
API/
V4/
6 lines

Diff 11885

View Options

src/app/Http/Controllers/API/V4/SkusController.php

Loading...