Paths

Table of Contentst

Differential D4057

User RESTRICTED status
ClosedPublic
Actions

Authored by machniak on Feb 3 2023, 11:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 20, 7:29 AM

	Unknown Object (File)
	Mon, May 20, 1:28 AM

	Unknown Object (File)
	Sun, May 19, 9:11 AM

	Unknown Object (File)
	Mon, May 13, 2:08 PM

	Unknown Object (File)
	Mon, May 6, 5:41 PM

	Unknown Object (File)
	Mon, May 6, 4:52 AM

	Unknown Object (File)
	Tue, Apr 30, 1:01 PM

	Unknown Object (File)
	Sun, Apr 21, 5:06 PM

View All 80 Files

Subscribers

Restricted Project

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rK43d8fa9d3c2a: User RESTRICTED status

Summary

Restricted flag for new users
Fix the user:resync test that was removing existing users
Display Restricted badge on user page for admins
Update Dusk, fix flaky test

Test Plan

./phpunit

Diff Detail

Repository

Branch

dev/status-restricted

Lint

Lint Skipped

Unit

No Test Coverage

Build Status

Buildable 41500
Build 16636: arc lint + arc unit

Event Timeline

machniak requested review of this revision.Feb 3 2023, 11:20 AM

machniak created this revision.

Harbormaster completed remote builds in B41500: Diff 11581.Feb 3 2023, 11:20 AM

Small improvement, removed debug code

Harbormaster completed remote builds in B41503: Diff 11584.Feb 3 2023, 11:27 AM

mollekopf subscribed.Feb 3 2023, 12:36 PM

mollekopf added inline comments.

src/app/Http/Controllers/API/SignupController.php
318	Why is this change required? Is it just unrelated cleanup?

machniak added inline comments.Feb 3 2023, 12:50 PM

src/app/Http/Controllers/API/SignupController.php
318	Yes, it's unrelated cleanup. That's the only place in the controllers where we set NEW status, so for consistency I removed it. The NEW status is being set by observers.

mollekopf accepted this revision.Feb 3 2023, 12:53 PM

This revision is now accepted and ready to land.Feb 3 2023, 12:53 PM

Closed by commit rK43d8fa9d3c2a: User RESTRICTED status (authored by machniak). · Explain WhyFeb 3 2023, 2:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

app/

Backends/

1 line

Console/

Commands/

User/

RestrictCommand.php

39 lines

UnrestrictCommand.php

39 lines

Http/

Controllers/

API/

SignupController.php

2 lines

V4/

UsersController.php

1 line

Observers/

WalletObserver.php

12 lines

45 lines

2 lines

resources/

lang/

en/

1 line

vue/

Admin/

1 line

tests/

Browser/

Admin/

3 lines

3 lines

Feature/

Console/

User/

RestrictTest.php

58 lines

2 lines

UnrestrictTest.php

57 lines

Controller/

2 lines

24 lines

36 lines

29 lines

Unit/

2 lines

Diff 11581

src/app/Backends/Storage.php

Loading...

src/app/Console/Commands/User/RestrictCommand.php

Loading...

src/app/Console/Commands/User/UnrestrictCommand.php

Loading...

src/app/Http/Controllers/API/SignupController.php

Loading...

src/app/Http/Controllers/API/V4/UsersController.php

Loading...

src/app/Observers/WalletObserver.php

Loading...

src/app/User.php

Loading...

src/composer.json

Loading...

src/resources/lang/en/ui.php

Loading...

src/resources/vue/Admin/User.vue

Loading...

src/tests/Browser/Admin/UserTest.php

Loading...

src/tests/Browser/UsersTest.php

Loading...

src/tests/Feature/Console/User/RestrictTest.php

Loading...

src/tests/Feature/Console/User/ResyncTest.php

Loading...

src/tests/Feature/Console/User/UnrestrictTest.php

Loading...

src/tests/Feature/Controller/SignupTest.php

Loading...

src/tests/Feature/Controller/UsersTest.php

Loading...

src/tests/Feature/UserTest.php

Loading...

src/tests/Feature/WalletTest.php

Loading...

src/tests/Unit/UserTest.php

Loading...