Usage of $cal->get_owner() rather $cal->get_title() for title
Closed, ResolvedPublic


With rRPK7c07ad1d427cd9c75fc4c40fe15c520b5b046273 (as in current Winterfell) in plugins/calendar/drivers/kolab/kolab_driver.php for $cal instanceof kolab_storage_folder_user the following line was added:

'title'    => $cal->get_owner(),

But shouldn't that be instead:

'title'    => $cal->get_title(),

This would be at least consistent with all other calendar types in the same file (given they're using get_title() already).

Event Timeline

rsc created this task.Aug 23 2018, 4:09 AM
rsc added a project: Roundcube Kolab Plugins .

Probably it could, but in reality it doesn't make a big difference if you consider return value of both on kolab_storage_folder_user.