Page MenuHomePhorge
Create Task
Maniphest T1192

Fix events that have UTC start/end dates
Closed, ResolvedPublic
Actions

Description

This is almost never what you actually want, so we need to convert all UTC date-times floating time.

Details

Ticket Type
Task

Related Objects

Event Timeline

mollekopf created this task.Apr 12 2016, 11:23 AM
mollekopf raised the priority of this task from 40 to High.
mollekopf claimed this task.Apr 12 2016, 3:59 PM
mollekopf moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
mollekopf added a comment.Apr 14 2016, 12:06 PM
  • The tool will get a new option "--fix-utc-incidences"
  • With this option we will rerun the format upgrade against all users, which

will rewrite all objects and and change the start/end/due dates accordingly.

  • While rewriting the incidence we have to take dtstart, dtend, dtdue, rdate,

exdate and recurrenceid into account.

adomaitis added a project: Wheezy.Apr 15 2016, 5:22 AM
vanmeeuwen added a project: Kolab Enterprise 14.Apr 15 2016, 7:39 AM
mollekopf added a comment.Apr 15 2016, 7:42 AM

The implemented solution will use KDateTime::Spec::LocalZone() do determine the offset from utc to use for the conversion,
this requires either a working ktimezoned or a build with libcalendaring to get access to timezone information.

vanmeeuwen subscribed.Apr 15 2016, 7:52 AM

Does not build in Winterfell on Maipo:

[   98s] /home/abuild/rpmbuild/BUILD/kolab-utils-3.1.1/upgradetool/upgradeutilities.cpp:27:26: fatal error: KCalCore/Event: No such file or directory
[   98s]  #include <KCalCore/Event>
[   98s]                           ^
[   98s] compilation terminated.
[   98s] make[2]: *** [CMakeFiles/kolab-formatupgrade.dir/upgradetool/upgradeutilities.cpp.o] Error 1
[   98s] make[2]: Leaving directory `/home/abuild/rpmbuild/BUILD/kolab-utils-3.1.1/build'
[   98s] make[1]: *** [CMakeFiles/kolab-formatupgrade.dir/all] Error 2
[   98s] make[1]: Leaving directory `/home/abuild/rpmbuild/BUILD/kolab-utils-3.1.1/build'
[   98s] make: *** [all] Error 2
[   98s] error: Bad exit status from /var/tmp/rpm-tmp.ejc71j (%build)
[   98s] 
[   98s] 
[   98s] RPM build errors:
[   98s]     Bad exit status from /var/tmp/rpm-tmp.ejc71j (%build)
[   98s] 
[   98s] dws06.kolabsys.com failed "build kolab-utils.spec" at Fri Apr 15 07:48:37 UTC 2016.
[   98s] 

The buildroot was: /var/tmp/build-root/CentOS_7-x86_64

To blame is rUf85b31d84282: Option to convert UTC date-times to floating times.

vanmeeuwen added a comment.Apr 15 2016, 8:01 AM

Fixed by importing kcalcore/event.h and kdatetime.h rather than KCalCore/Event and KDateTime.

vanmeeuwen added a comment.Apr 15 2016, 8:08 AM

Fails to build on Stretch as well, due to an undefined KDE_KIMAPTEST cmake variable. For now, patching out the inclusion of fbdaemon/tests/.

vanmeeuwen added a comment.Apr 15 2016, 8:25 AM

Fails to build on Twenty Three with the same KDE_KIMAPTEST cmake variable ending up undefined.

vanmeeuwen added a comment.Apr 15 2016, 8:45 AM

Builds scheduled.

vanmeeuwen added a comment.Apr 15 2016, 9:02 AM

Builds completed, rebuilding for Kolab Enterprise 14 Santiago and Maipo

vanmeeuwen added a comment.Apr 15 2016, 9:05 AM

Pushing to mirror for Wheezy and Jessie

vanmeeuwen closed this task as Resolved.Apr 15 2016, 9:08 AM

Done

mollekopf moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Apr 15 2016, 4:07 PM
petersen subscribed.Apr 21 2016, 8:58 AM