Page MenuHomePhorge

Fix bug where reply wasn't send to organizer on task status update (#5341)
ClosedPublic

Authored by machniak on Mar 11 2016, 2:44 PM.
Referenced Files
Unknown Object (File)
Mon, Mar 25, 9:39 PM
Unknown Object (File)
Mon, Mar 25, 9:39 PM
Unknown Object (File)
Mon, Mar 25, 9:39 PM
Unknown Object (File)
Mon, Mar 25, 9:33 PM
Unknown Object (File)
Mon, Mar 18, 3:03 AM
Unknown Object (File)
Thu, Feb 29, 3:22 PM
Unknown Object (File)
Feb 15 2024, 7:17 AM
Unknown Object (File)
Feb 15 2024, 4:17 AM
Subscribers

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak retitled this revision from to Fix bug where reply wasn't send to organizer on task status update (#5341).
machniak updated this object.
machniak edited the test plan for this revision. (Show Details)

Is it at all relevant, whether the initiator is or is not the organizer?

I think it's not relevant. The modified code before the change was setting _notify flag when edited/new event has any attendees, no matter the user is organizer or the attendee. In comparison with the php code which calls notify_attendees() when _notify flag is set, it does not make sense. So, I modified the code to not set the _notify flag if the originator is an attendee.

However, when I'm looking at this closer I see that still might not resolve the issue fully. The issue talks about a case when there's organizer and one attendee, what if there's more attendees? has_attendees() will return true and notification to the organizer still will not be send. More work on this needed.

Handle _reportpartstat an _notify separately

vanmeeuwen added a reviewer: vanmeeuwen.

Pushing the package through updates-testing should resolve any doubt that may still exist.

This revision is now accepted and ready to land.Apr 14 2016, 11:23 AM
This revision was automatically updated to reflect the committed changes.