Page MenuHomekolab.org

Dusk browser extensions
ClosedPublic

Authored by machniak on Mar 2 2020, 8:48 PM.

Details

Summary

Added possibility to extend dusk browser object.
Added possibility to run tests in phone/tablet/desktop mode.

TODO: Fix tests in phone and tablet mode

Test Plan

./phpunit --testsuite=Browser

Diff Detail

Repository
rK kolab
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

machniak requested review of this revision.Mar 2 2020, 8:48 PM
machniak created this revision.
vanmeeuwen accepted this revision.Mar 2 2020, 10:15 PM

I trust this is a non-intrusive change, but ffs, zero-regression;

While there's no refined definition for desktop UX, let alone phone/tablet, the latter few are not the focal points of our efforts to date I hope.

This revision is now accepted and ready to land.Mar 2 2020, 10:15 PM

Yes, I just copied some code I already have had in Roundcube for future use. The main point was to have possibility to extend the browser object with some helper code, to simplify tests writing.

This revision was automatically updated to reflect the committed changes.