Paths

Table of Contentst

Differential D94

Fix duplicated events in other users calendar if its subfolders are active (#5340)
ClosedPublic
Actions

Authored by machniak on Mar 2 2016, 3:47 PM.

Project Tags

None

Referenced Files

	F117358245: D94.1774813521.diff
	Sat, Mar 28, 7:45 PM

Subscribers

Details

Reviewers

Group Reviewers

Roundcube Kolab Plugins Developers

Commits

rRPKb01894ee2d18: Fix duplicated events in other users calendar if its subfolders are active…
rRPK2afb5714c549: Fix duplicated events in other users calendar if its subfolders are active…

Diff Detail

Repository

rRPK roundcubemail-plugins-kolab

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

machniak updated this revision to Diff 193.Mar 2 2016, 3:47 PM

machniak retitled this revision from to Fix duplicated events in other users calendar if its subfolders are active (#5340).

machniak added a reviewer: bruederli.Mar 2 2016, 3:48 PM

Set the reviewers to the developer group please.

Fix matching recurring tasks with today/tomorrow/later filter (#4205)

Fix matching recurring tasks with today/tomorrow/later filter (#4205)
Revert "Fix matching recurring tasks with today/tomorrow/later filter (#4205)"

Cleanup

This patch also applies to roundcubemail-plugins-kolab-3.2.

This revision is now accepted and ready to land.Mar 6 2016, 8:09 AM

From what I can see this could indeed work around the inconsistency described in #5340. It might still show some (temporary) duplicates in the calendar view until the user calendar is fully refreshed. Deciding when and what to reload should better be done on the client.

plugins/calendar/calendar_ui.js
2970	This is really an ugly hack. I wasn't aware that `refetchEvents` has issues. Should maybe be fixed independent to this.

Closed by commit rRPK2afb5714c549: Fix duplicated events in other users calendar if its subfolders are active… (authored by machniak, committed by machniak). · Explain WhyMar 11 2016, 10:41 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

plugins/

calendar/

lines

lines

drivers/

kolab/

kolab_user_calendar.php

lines

libkolab/

lib/

kolab_storage.php

lines

Diff 211

plugins/calendar/calendar.php

Loading...

plugins/calendar/calendar_ui.js

Loading...

plugins/calendar/drivers/kolab/kolab_user_calendar.php

Loading...

plugins/libkolab/lib/kolab_storage.php

Loading...