Page MenuHomePhorge
Differential D94

Fix duplicated events in other users calendar if its subfolders are active (#5340)
ClosedPublic
Actions

Authored by machniak on Mar 2 2016, 4:47 PM.
Tags
None
Referenced Files
F11772138: D94.diff
Wed, Apr 17, 12:59 PM
Unknown Object (File)
Wed, Apr 10, 5:37 AM
Unknown Object (File)
Mon, Apr 8, 11:09 PM
Unknown Object (File)
Sun, Apr 7, 12:51 PM
Unknown Object (File)
Mon, Mar 25, 3:03 AM
Unknown Object (File)
Mon, Mar 25, 3:03 AM
Unknown Object (File)
Mon, Mar 25, 3:03 AM
Unknown Object (File)
Mon, Mar 25, 3:03 AM
View All Files
Subscribers
bruederli
vanmeeuwen

Details

Reviewers
vanmeeuwen
Group Reviewers
Roundcube Kolab Plugins Developers
Commits
rRPKb01894ee2d18: Fix duplicated events in other users calendar if its subfolders are active…
rRPK2afb5714c549: Fix duplicated events in other users calendar if its subfolders are active…

Diff Detail

Repository
rRPK roundcubemail-plugins-kolab
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

machniak updated this revision to Diff 193.Mar 2 2016, 4:47 PM
machniak retitled this revision from to Fix duplicated events in other users calendar if its subfolders are active (#5340).
machniak added a reviewer: bruederli.Mar 2 2016, 4:48 PM
vanmeeuwen edited reviewers, added: Roundcube Kolab Plugins Developers; removed: bruederli.Mar 2 2016, 5:12 PM
vanmeeuwen subscribed.

Set the reviewers to the developer group please.

machniak updated this revision to Diff 194.Mar 4 2016, 10:57 AM
  • Fix matching recurring tasks with today/tomorrow/later filter (#4205)
machniak updated this revision to Diff 195.Mar 4 2016, 10:59 AM
  • Fix matching recurring tasks with today/tomorrow/later filter (#4205)
  • Revert "Fix matching recurring tasks with today/tomorrow/later filter (#4205)"
machniak updated this revision to Diff 196.Mar 4 2016, 11:04 AM

Cleanup

vanmeeuwen accepted this revision.Mar 6 2016, 9:09 AM
vanmeeuwen added a reviewer: vanmeeuwen.

This patch also applies to roundcubemail-plugins-kolab-3.2.

This revision is now accepted and ready to land.Mar 6 2016, 9:09 AM
bruederli subscribed.Mar 7 2016, 2:39 PM

From what I can see this could indeed work around the inconsistency described in #5340. It might still show some (temporary) duplicates in the calendar view until the user calendar is fully refreshed. Deciding when and what to reload should better be done on the client.

plugins/calendar/calendar_ui.js
2970

This is really an ugly hack. I wasn't aware that refetchEvents has issues. Should maybe be fixed independent to this.

Closed by commit rRPK2afb5714c549: Fix duplicated events in other users calendar if its subfolders are active… (authored by machniak, committed by machniak). · Explain WhyMar 11 2016, 11:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
plugins/
calendar/
16 lines
10 lines
drivers/
kolab/
6 lines
libkolab/
lib/
48 lines

Diff 211

View Options

plugins/calendar/calendar.php

Loading...
View Options

plugins/calendar/calendar_ui.js

Loading...
View Options

plugins/calendar/drivers/kolab/kolab_user_calendar.php

Loading...
View Options

plugins/libkolab/lib/kolab_storage.php

Loading...