Fix many warnings: #warning "Inclusion of header files from include/Qt is deprecated."
AcceptedPublic
Actions

Authored by dfaure on Jan 12 2016, 11:44 PM.

Tags

Referenced Files

	Unknown Object (File)
	Mon, Oct 14, 1:24 AM

	Unknown Object (File)
	Thu, Oct 10, 8:22 AM

	Unknown Object (File)
	Mon, Oct 7, 1:55 PM

	Unknown Object (File)
	Fri, Sep 27, 1:56 PM

	Unknown Object (File)
	Fri, Sep 27, 11:46 AM

	Unknown Object (File)
	Fri, Sep 27, 11:44 AM

	Unknown Object (File)
	Fri, Sep 27, 11:43 AM

	Unknown Object (File)
	Thu, Sep 26, 2:04 AM

View All Files

Subscribers

None

Details

Reviewers

mollekopf

Summary

When using find_package(Qt4), QT_INCLUDES has include/QtCore before include/Qt (as it should be) but somehow leads to -isystem for include/QtCore and -I for include/Qt, so qglobal.h and others are picked up from include/Qt.

But we never hit this in KDE because we don't use find_package(Qt4) directly, we let find_package(KDE4) take care of it, somehow it doesn't lead to -isystem.

Diff Detail

Repository

rLK libkolab

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dfaure updated this revision to Diff 144.Jan 12 2016, 11:44 PM

dfaure retitled this revision from to Fix many warnings: #warning "Inclusion of header files from include/Qt is deprecated.".

dfaure updated this object.

dfaure edited the test plan for this revision. (Show Details)

dfaure added a reviewer: mollekopf.

dfaure set the repository for this revision to rLK libkolab.

dfaure added a project: KDE PIM Developers.

Thanks for the patch =)

Sorry this took so long, I missed that there were reviews pending

This revision is now accepted and ready to land.Jan 20 2016, 12:19 PM

Revision Contents
Changeset List

Path

Size

CMakeLists.txt

4 lines

Diff 144

View Options

Fix many warnings: #warning "Inclusion of header files from include/Qt is deprecated."AcceptedPublicActions